Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

get_logger uses root directory file #784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EarthmanT
Copy link

@EarthmanT EarthmanT commented Oct 27, 2021

No automation system should have write access to this file.
https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/

To help us process your pull request efficiently, please include:

  • (Required) Short description of changes in the PR topic line

  • (Required) Detailed description of changes include tests and
    documentation. If the pull request contains multiple commits with
    detailed messages, refer to those instead

  • (Optional) Names of reviewers using @ sign + name


This change is Reviewable

@vmwclabot
Copy link

@EarthmanT, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@EarthmanT, VMware has approved your signed contributor license agreement.

Copy link
Contributor

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EarthmanT)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants